Add missing Python type annotations to code in dev_tools/#1298
Open
mhucka wants to merge 5 commits intoquantumlib:mainfrom
Open
Add missing Python type annotations to code in dev_tools/#1298mhucka wants to merge 5 commits intoquantumlib:mainfrom
dev_tools/#1298mhucka wants to merge 5 commits intoquantumlib:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances type safety across various development tools by adding type hints to functions, methods, and test cases. It also refines imports and documentation in scripts like shell_tools.py and run-pip-compiles.py. A critical feedback point identifies a runtime error in run-pip-compiles.py caused by the incorrect use of subprocess.CompletedProcess as a generic type, which is not supported in all Python versions.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds type annotations where they were missing in some files under
dev_tools/. This is limited in scope and was done partly to experiment with using Gemini CLI to do such tasks.This partly addresses #1282.