fix: Add WASM artifact verification before publish #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add verification step in release workflow to ensure all WASM artifacts are present before publishing to npm. This prevents incomplete packages from being published if any matrix build job fails. The verification checks for WASM files from all four bands: - v0_82_87 - v26 - v42 - v48 If any band is missing artifacts, the workflow will fail with a clear error message before reaching the publish step. This replaces the silent failure behavior of the previous "cp ... || true" command.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
❇️ CodePress Review Summary
👋 Hey team,
Overall the changes look great! No specific issues found.
Here's the quick rundown:
✅ Decision: APPROVE
The added verification step improves release safety and has no identified blocking issues. Risks are maintenance-related (band list, paths) but not merge-blocking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a verification step in the GitHub Actions release workflow to ensure all WASM artifacts are present before publishing to npm.
Problem
In the current workflow, the "Combine WASM artifacts" step uses:
This command silently ignores missing WASM files (
|| truesuppresses errors). If any of the matrix build jobs fail to produce artifacts, the publish step will proceed with an incomplete package, leading to runtime errors when users try to use the missing bands.Solution
Added a new "Verify all WASM files present" step that:
v0_82_87,v26,v42,v48This ensures the workflow fails fast before publishing an incomplete package, making it immediately clear when a matrix job has failed.
Testing
The verification step will: