docs: tick CODE_QUALITY_TODO for src/cli/dispatch.rs (#102)#180
Open
quangdang46 wants to merge 1 commit into
Open
docs: tick CODE_QUALITY_TODO for src/cli/dispatch.rs (#102)#180quangdang46 wants to merge 1 commit into
quangdang46 wants to merge 1 commit into
Conversation
The deprecated #[allow(deprecated)] / unused_mut suppressions in src/cli/dispatch.rs guarded the now-removed `Args::standalone` flag (removed locally in commit eaf7bf0 "Remove standalone references" on top of the cli module extract in 568b0d8). The suppressions themselves are gone, so the TODO entry is stale. Tick it. Refs upstream PR 1jehuang#124 (which performed the equivalent removal upstream). Closes #102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
--standaloneflag and its associated#[allow(deprecated)]/unused_mutsuppressions insrc/cli/dispatch.rswere already removedlocally:
568b0d80extracted the CLI modules from main.rs.eaf7bf00"Remove standalone references" deleted the deprecated flag and its associated suppressions.grep -RnE 'standalone|args\.standalone' src/cli/andgrep -nE '#\[allow|#\[expect|deprecated|unused_mut' src/cli/dispatch.rsboth return empty.What remained was a stale entry in
docs/CODE_QUALITY_TODO.mdstill listing the(deprecated, unused_mut, unused_mut)suppressions forsrc/cli/dispatch.rsas outstanding. Tick it.This addresses issue #102 (which mirrored upstream PR 1jehuang#124).
Changes
src/cli/dispatch.rsentry.Tests
Doc-only change.
Notes
The actual code removal that upstream PR #124 performs has already happened in this fork. No further code change is needed.