Skip to content

Add upstream patch to disable ASPM L0s for SA8775P#2176

Open
Kavinaya99 wants to merge 1 commit into
qualcomm-linux:masterfrom
Kavinaya99:pcie-revert
Open

Add upstream patch to disable ASPM L0s for SA8775P#2176
Kavinaya99 wants to merge 1 commit into
qualcomm-linux:masterfrom
Kavinaya99:pcie-revert

Conversation

@Kavinaya99
Copy link
Copy Markdown
Contributor

@Kavinaya99 Kavinaya99 commented May 13, 2026

Add upstream patch to disable ASPM L0s for SA8775P

Subject: [PATCH] Revert "PCI: dwc: Remove MSI/MSIX capability for Root Port if
iMSI-RX is used as MSI controller"

Upstream-Status: Inappropriate [platform-specific regression workaround]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misplaced tag (all tags should be at the end of the commit message).

Please get this sorted out upstream and then provide a backport here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, uploaded the new patch with the modifications

@vkraleti
Copy link
Copy Markdown
Contributor

@Kavinaya99

https://lore.kernel.org/all/20260419093934.1223027-1-shengchao.guo@oss.qualcomm.com/ should solve this. You may bring this change as a "Submitted:" patch to unblock Leamans testing.

@lumag
Copy link
Copy Markdown
Contributor

lumag commented May 13, 2026

@Kavinaya99

https://lore.kernel.org/all/20260419093934.1223027-1-shengchao.guo@oss.qualcomm.com/ should solve this. You may bring this change as a "Submitted:" patch to unblock Leamans testing.

@vkraleti please don't give bad advices. See the responses from Mani. The patch is invalid.

Add an upstream-submitted PCIe patch that disables ASPM L0s for the
SA8775P Root Port configuration. This avoids Data Link Layer Replay
Timer Timeout errors observed on SA8775P/Lemans platforms during early
boot.

Signed-off-by: Kavinaya S <kavinaya@qti.qualcomm.com>
@vkraleti
Copy link
Copy Markdown
Contributor

vkraleti commented May 13, 2026

@Kavinaya99
https://lore.kernel.org/all/20260419093934.1223027-1-shengchao.guo@oss.qualcomm.com/ should solve this. You may bring this change as a "Submitted:" patch to unblock Leamans testing.

@vkraleti please don't give bad advices. See the responses from Mani. The patch is invalid.

Agree this isn’t a right change. However, we need to unblock linux-yocto-dev testing on Lemans. The last successful testing was on 6.19, about two months ago. Since then, we haven’t been able to validate Lemans on any newer upstream kernels.

At this point, it looks like we have only two viable options:

  1. Revert the culprit change, or
  2. Carry this patch as a stop‑gap.

Are there any better suggestions?

@vkraleti
Copy link
Copy Markdown
Contributor

BTW, qcom-next took the revert approach to unblock.
qualcomm-linux/kernel@c94608e

@lumag
Copy link
Copy Markdown
Contributor

lumag commented May 13, 2026

@vkraleti Neither of the patches is correct. The revert simply enables unsupported capability, possibly causing MSI interrupts to be missed.

What is causing AER erorrs? Could we try lowering PCIe link speed instead?

@Kavinaya99 Kavinaya99 changed the title Revert PCI dwc MSIX change causing PCIe regression Add upstream patch to disable ASPM L0s for SA8775P May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants