Skip to content

572 join error#670

Open
idruzhitskiy wants to merge 14 commits intomasterfrom
572-join-error
Open

572 join error#670
idruzhitskiy wants to merge 14 commits intomasterfrom
572-join-error

Conversation

@idruzhitskiy
Copy link
Copy Markdown
Contributor

Closes #572

Comment thread bob/src/cluster/operations.rs Outdated
Comment thread bob/src/cluster/operations.rs Outdated
@ikopylov
Copy link
Copy Markdown
Member

I searched for information about the cancelled error. There are comments in several places where it is indicated that there is a possibility that there will be a cancellation error when the runtime is stopped. Comments are here:

  1. Observability of JoinError::Cancelled tokio-rs/tokio#2077 (comment)
  2. https://users.rust-lang.org/t/can-this-tokio-task-get-canceled-if-i-await-its-handle/88203/4

So, unfortunately, we should handle cancelled error in a special way

Comment thread bob/src/cluster/support_types.rs Outdated
Comment thread bob/src/cluster/operations.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question: best JoinError handling

2 participants