Skip to content

refactor: use LIEF for binary parsing#1626

Open
nullableVoidPtr wants to merge 4 commits intoqilingframework:devfrom
nullableVoidPtr:lief
Open

refactor: use LIEF for binary parsing#1626
nullableVoidPtr wants to merge 4 commits intoqilingframework:devfrom
nullableVoidPtr:lief

Conversation

@nullableVoidPtr
Copy link
Copy Markdown
Contributor

Checklist

Massive refactor - leaving as draft for now pending review.

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


This will need some testing particularly from @xwings since I don't have all of the rootfs for testing.

@nullableVoidPtr
Copy link
Copy Markdown
Contributor Author

Need to merge to dev, haven't synced in a while.

@xwings
Copy link
Copy Markdown
Member

xwings commented May 2, 2026

Hi,

thanks for the PR. Two things

  1. make sure we are PR to dev branch
  2. we need to make sure the test works

Looking forward for the fix.

@nullableVoidPtr nullableVoidPtr changed the base branch from master to dev May 4, 2026 03:59
@nullableVoidPtr nullableVoidPtr marked this pull request as ready for review May 4, 2026 04:00
@nullableVoidPtr
Copy link
Copy Markdown
Contributor Author

Ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants