Conversation
…q_reduce which also works with any context polynomial and is not limited to the underlying field requirements
…g monic polynomials
LPorzenheim
requested changes
Jan 15, 2026
Member
LPorzenheim
left a comment
There was a problem hiding this comment.
Did not recalculate every changed test manually, but looked at whether they seemed reasonable.
…sts, move function to different file and optimise functional separation
Marvin-Beckmann
commented
Jan 19, 2026
Member
Author
Marvin-Beckmann
left a comment
There was a problem hiding this comment.
I made these and a few more changes that I found necessary
LPorzenheim
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, our ModulusPolynomialRingZq reduce used the fq_reduce from FLINT. However, the fq objects from FLINT do not support arbitrary moduli and only irreducible polynomials (in general).
In the few special cases that were important for our usecases this never occured, as we have mostly sparse polynomials and the sparse reduce works without the irreducible property.
Gennerally, this meant that the error was unnoticed.
This PR introduces its own sparse reduce function without use of FLINTs function. This removes the underlying dependency to FLINT. The method allows any modulus and any context polynomial (assuming it is monic).
Testing
Checklist: