Skip to content

Fix snippets generation for sandboxed builds#269

Closed
xzfc wants to merge 2 commits intomasterfrom
fix-snippets
Closed

Fix snippets generation for sandboxed builds#269
xzfc wants to merge 2 commits intomasterfrom
fix-snippets

Conversation

@xzfc
Copy link
Member

@xzfc xzfc commented Feb 24, 2026

Two issues:

This PR fixes both of them.


Alternative solutions (not in this PR):

  • Move snippet tests into a separate crate within the workspace. Do not ship this test crate to crates.io.
  • If we want to put autogenerated files in tests/snippet_tests/, then we should do it by a separate script, not by build.rs.

We don't need downstream users to build these tests.
@xzfc xzfc requested review from generall and timvisee February 24, 2026 04:05
@timvisee
Copy link
Member

These are probably related: #235, #239

Copy link
Member

@generall generall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In call we agreed to abandon "nice" version of the snippets, as we have snippets checker in documentation, and only keep generated version

@xzfc
Copy link
Member Author

xzfc commented Mar 19, 2026

Superseded by #275.

@xzfc xzfc closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants