Skip to content

Conversation

@djhoese
Copy link
Member

@djhoese djhoese commented Sep 10, 2025

We get warnings when the modis interpolator cython module is compiled. This PR fixes them. Because the tests pass I assume these changes are fine. Without the rearranging of the parameters in the one modified expression tests fail.


geotiepoints/_modis_interpolator.c: In function ‘__pyx_fuse_0__pyx_f_12geotiepoints_19_modis_interpolator_17MODISInterpolator__get_coords_1km’:
geotiepoints/_modis_interpolator.c:27438:33: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
27438 |   for (__pyx_t_3 = 0; __pyx_t_3 < __pyx_t_2; __pyx_t_3+=1) {
      |                                 ^
geotiepoints/_modis_interpolator.c:27482:35: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
27482 |     __pyx_t_4 = (__pyx_v_fine_idx >= (__pyx_v_fine_pixels_per_scan - __pyx_v_half_scan_length));
      |                                   ^~
geotiepoints/_modis_interpolator.c: In function ‘__pyx_fuse_1__pyx_f_12geotiepoints_19_modis_interpolator_17MODISInterpolator__get_coords_1km’:
geotiepoints/_modis_interpolator.c:27622:33: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
27622 |   for (__pyx_t_3 = 0; __pyx_t_3 < __pyx_t_2; __pyx_t_3+=1) {
      |                                 ^
geotiepoints/_modis_interpolator.c:27666:35: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
27666 |     __pyx_t_4 = (__pyx_v_fine_idx >= (__pyx_v_fine_pixels_per_scan - __pyx_v_half_scan_length));
      |                                   ^~
  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@djhoese djhoese requested a review from mraspaud September 10, 2025 16:30
@djhoese djhoese self-assigned this Sep 10, 2025
@djhoese djhoese added the bug label Sep 10, 2025
@djhoese djhoese changed the title Fix compiler warnings in MODIS interpolator Fix gcc compiler warnings in MODIS interpolator Sep 10, 2025
@djhoese
Copy link
Member Author

djhoese commented Sep 10, 2025

Just checked CI and the Windows compiler warns on a lot more stuff, but I'm not too concerned about them...for now.

@coveralls
Copy link

Coverage Status

coverage: 87.965%. remained the same
when pulling 8e50a9b on djhoese:bugfix-compile-warnings
into a28d54c on pytroll:main.

@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.69%. Comparing base (ffc1628) to head (8e50a9b).
⚠️ Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   88.43%   88.69%   +0.25%     
==========================================
  Files          20       20              
  Lines        1522     1521       -1     
==========================================
+ Hits         1346     1349       +3     
+ Misses        176      172       -4     
Flag Coverage Δ
unittests 88.69% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 184a2f2 into pytroll:main Sep 10, 2025
26 checks passed
@djhoese djhoese deleted the bugfix-compile-warnings branch September 10, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants