Add resample force kwarg#726
Open
ameraner wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
+ Coverage 93.66% 93.68% +0.02%
==========================================
Files 89 89
Lines 13707 13715 +8
==========================================
+ Hits 12838 12849 +11
+ Misses 869 866 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djhoese
approved these changes
May 21, 2026
Member
djhoese
left a comment
There was a problem hiding this comment.
Looks good to me. I can't help but think this smells like we're doing something wrong in Satpy's design that this is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
forcekwarg to theresampler.resamplecall. When set toTrue, it bypasses the area equality checks that skip the resampling if the geometries are the same. This is useful e.g. when data has NaN gaps (for example after a parallax correction) and one wants to gapfill it, e.g. with nearest neighbour.geometries_are_the_samecheck #660