Add support to take bounding box info from metadata passed from the level-1 reader#724
Draft
adybbroe wants to merge 2 commits into
Draft
Add support to take bounding box info from metadata passed from the level-1 reader#724adybbroe wants to merge 2 commits into
adybbroe wants to merge 2 commits into
Conversation
… instead of calculating it from the geolocation data Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
djhoese
reviewed
May 20, 2026
Comment on lines
+945
to
+950
| mask = thelons.notnull().compute() | ||
| thelons = thelons.where(mask, drop=True) | ||
|
|
||
| thelats = self.lats[:, int(cols / 2)] | ||
| thelats = thelats.where(thelats.notnull(), drop=True) | ||
| mask = thelats.notnull().compute() | ||
| thelats = thelats.where(mask, drop=True) |
Member
There was a problem hiding this comment.
It would be good to do the compute at the same time like thelons, thelats = da.compute(thelons.notnull(), thelats.notnull()). That way any shared computation tasks are only run once.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 93.66% 93.59% -0.07%
==========================================
Files 89 89
Lines 13707 13735 +28
==========================================
+ Hits 12838 12855 +17
- Misses 869 880 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support to take bounding box info from metadata in the area object instead of calculating it from the geolocation data