Use pyproject.toml fully instead of setup.py#721
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 93.66% 93.66%
=======================================
Files 89 89
Lines 13707 13707
=======================================
Hits 12838 12838
Misses 869 869
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| { platforms = ["linux", "darwin", "freebsd"], arg = "-O3" }, | ||
| { platforms = ["linux", "darwin", "freebsd"], arg = "-Wno-unused-function" }, |
There was a problem hiding this comment.
These 2 lines can't be combined?
There was a problem hiding this comment.
My understanding is that hatch-cython wants them separate
djhoese
left a comment
There was a problem hiding this comment.
The unstable environment in CI might need to be updated to not install versioneer. And maybe the RTD config too.
I'm fine with this, but it does scare me for any further customizations that we may want. For example, I think pykdtree's setup.py has a lot of custom stuff depending on what it finds in the environment (ex. OpenMP) so I'm worried about what pyresample would have to do to handle a similar case.
|
This saved my (PCW) week, thanks Martin! |
|
Should close #722 (edited the pre-amble reflecting that - see above) |
Noted! I think we will be able to fix this though, so we'll go ahead and merge this. |
Use pyproject.toml to entirely remove setup.py
This PR was generated mainly using AI