Add units parameter to resolution warning log - at least in some cases#699
Merged
djhoese merged 1 commit intopytroll:mainfrom Feb 24, 2026
Merged
Add units parameter to resolution warning log - at least in some cases#699djhoese merged 1 commit intopytroll:mainfrom
djhoese merged 1 commit intopytroll:mainfrom
Conversation
Member
|
Thanks Levi. The thing that jumps out to me about this is that the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
=======================================
Coverage 93.67% 93.67%
=======================================
Files 89 89
Lines 13621 13621
=======================================
Hits 12759 12759
Misses 862 862
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks Levi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request to fix #458 (and fixes the example of the problem given in that ticket.)
It does so by adding an optional parameter units to the _round_shape function and having _extrapolate_information give the appropriate units when calling _round_shape.
This should fix all instances of this as the warning only has the potential to be thrown when resolution and radius are both set and the only other instance of calling _round_shape (in _format_list) does not set those parameters.