Update EWA pyproj Proj usage to Transformer#648
Merged
djhoese merged 3 commits intopytroll:mainfrom Feb 18, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
=======================================
Coverage 93.97% 93.98%
=======================================
Files 86 86
Lines 13536 13543 +7
=======================================
+ Hits 12721 12728 +7
Misses 815 815
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b85aaa3 to
98f20a7
Compare
4 tasks
Member
Author
|
Merging this to get the versioneer fixes and also I'm the primary EWA user anyway so...it should be fine and if not I'll fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pyproj
Projobject is deprecated and is not as accurate/explicit as theTransformerinterface. I did some of these changes in my #645 branch, but decided that these changes should be their own PR. Unfortunately this also meant that I changed the low-level interfaces of ll2cr to accept a source CRS and a target CRS instead of just the target projection information.