[Future Spherical Class] Add SPoint and SMultiPoint#465
[Future Spherical Class] Add SPoint and SMultiPoint#465mraspaud merged 20 commits intopytroll:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 94.27% 94.24% -0.04%
==========================================
Files 69 73 +4
Lines 12394 12703 +309
==========================================
+ Hits 11685 11972 +287
- Misses 709 731 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mraspaud
left a comment
There was a problem hiding this comment.
Thanks for taking on the job of renovating this part of Pyresample, it is highly needed! Some suggestions, questions and comments inline.
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
mraspaud
left a comment
There was a problem hiding this comment.
Thanks, starts to look good.
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
djhoese
left a comment
There was a problem hiding this comment.
This is looking really good. I haven't kept up on this development so I had a lot of questions and a couple requested changes, but otherwise I like how you cleaned up the code.
One other suggestion that may help tests in the future, should some of these SCoordinate objects you use in the tests be pytest fixtures or other helper methods so the code to generate them doesn't get repeated all over the tests? I see some of them are unique, but also some use the same angles as inputs.
Again, nice job, just a few more things.
Co-authored-by: David Hoese <david.hoese@ssec.wisc.edu>
Co-authored-by: David Hoese <david.hoese@ssec.wisc.edu>
Co-authored-by: David Hoese <david.hoese@ssec.wisc.edu>
|
I just added a small class method |
djhoese
left a comment
There was a problem hiding this comment.
This looks good enough for me that it shouldn't be holding up any other PRs. I had one comment about something I wouldn't mind changed, but it isn't as big of a deal as the other stuff you've already fixed.
This PR add the SPoint and SMultiPoint class of the future spherical geometry interface.
git diff origin/main **/*py | flake8 --diff