Skip to content

Conversation

@UtkarshSingh31
Copy link

@UtkarshSingh31 UtkarshSingh31 commented Jan 27, 2026

Description

This PR simplifies the computation of the training progress counter (current) in the optimization tutorial.

The existing example computes current using a global batch_size variable. While this works in the current context, it introduces an unnecessary dependency on global state and can make the example harder to reason about or reuse if modified.

Computing current as batch * len(X) directly reflects the number of samples processed so far, avoids reliance on external assumptions, and naturally handles variable batch sizes.

This change affects logging only and does not modify training behavior or results.

Checklist

  • This pull request addresses a single, focused documentation improvement
  • No unrelated changes are included
  • The change improves clarity and robustness without affecting behavior

Happy to adjust wording or implementation if there is a preferred tutorial style.

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 27, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3749

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Jan 27, 2026

Hi @UtkarshSingh31!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the cla signed label Jan 27, 2026
@meta-cla
Copy link

meta-cla bot commented Jan 27, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant