[Feature] Agentic toolkit foundation: protocols, parsers, sandbox, REPL#3735
Open
vmoens wants to merge 1 commit intogh/vmoens/266/basefrom
Open
[Feature] Agentic toolkit foundation: protocols, parsers, sandbox, REPL#3735vmoens wants to merge 1 commit intogh/vmoens/266/basefrom
vmoens wants to merge 1 commit intogh/vmoens/266/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3735
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 500e59a with merge base d386287 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This was referenced May 10, 2026
github-actions
Bot
added
Feature
vmoens
commented
May 10, 2026
Comment on lines
+39
to
+40
| (``ToolCompose``) lands in a follow-up commit; this preview ships the | ||
| contracts, parsers, sandboxing, and stateful REPLs that it builds on. |
Collaborator
Author
There was a problem hiding this comment.
never ever mention commit strategy in a PR
vmoens
commented
May 10, 2026
| (``ToolCompose``) lands in a follow-up commit; this preview ships the | ||
| contracts, parsers, sandboxing, and stateful REPLs that it builds on. | ||
|
|
||
| Tool contracts |
Collaborator
Author
There was a problem hiding this comment.
this comes too fast. I need to see an example before.
vmoens
commented
May 10, 2026
Comment on lines
+99
to
+100
| isolation, prefer :class:`DockerSandbox` (real implementation | ||
| tracked in the package TODO list). |
Collaborator
Author
There was a problem hiding this comment.
we need to find a better way of doing this than a TODO list...
vmoens
commented
May 10, 2026
Comment on lines
+723
to
+730
| # --------------------------------------------------------------------------- | ||
| # Agentic toolkit (torchrl.envs.llm.agentic) | ||
| # --------------------------------------------------------------------------- | ||
|
|
||
| import asyncio # noqa: E402 | ||
| import socket # noqa: E402 | ||
| import sys # noqa: E402 | ||
| import warnings # noqa: E402 |
Collaborator
Author
There was a problem hiding this comment.
this clearly needs to be put in a separate test file!
vmoens
commented
May 10, 2026
Collaborator
Author
There was a problem hiding this comment.
use tensorclass, not dataclasses. we can stack tensorclasses and pass them to tensordicts. They will play nicely with batched envs, trajectories etc.
vmoens
commented
May 10, 2026
Collaborator
Author
There was a problem hiding this comment.
same, use tensorclasses and not dataclasses
vmoens
commented
May 10, 2026
Collaborator
Author
There was a problem hiding this comment.
ditto: tensorclass and dataclass
vmoens
commented
May 10, 2026
Comment on lines
+21
to
+27
| { | ||
| "message": "Let me search.", | ||
| "tools": [ | ||
| {"tool": "search", "args": {"query": "x"}, "id": "c1"}, | ||
| {"tool": "summarize", "args": {"text": "..."}} | ||
| ] | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
how will this be displayed in sphinx?
Worried about the lack of code block or something like that
vmoens
commented
May 10, 2026
Comment on lines
+25
to
+33
|
|
||
| { | ||
| "role": "assistant", | ||
| "content": [ | ||
| {"type": "text", "text": "Let me search."}, | ||
| {"type": "tool_use", "id": "toolu_1", | ||
| "name": "search", "input": {"q": "x"}} | ||
| ] | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
ditto: worried about how this will be displayed
vmoens
commented
May 10, 2026
|
|
||
| - The full message dict:: | ||
|
|
||
| {"role": "assistant", "content": "...", "tool_calls": [...]} |
vmoens
commented
May 10, 2026
|
|
||
| - The choice dict:: | ||
|
|
||
| {"message": {... "tool_calls": [...]}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Lands the substrate for an async-first, sandboxed tool-calling stack
under torchrl.envs.llm.agentic. ChatEnv is unchanged; the orchestrator
(ToolCompose) and built-in tools come in follow-up commits.
This commit ships:
TextPart/JsonPart/ImagePart/FileRefPart), ToolCallParser, ParsedCall,
ParseResult, with a stable call_id invariant pinned across all
parsers.
OpenAIToolCallParser, AnthropicToolUseParser. All round-trip
parse->render_call and produce stable call_ids.
(Linux default), SeatbeltSandbox (macOS default),
UnsafeSubprocessSandbox (warning-loud fallback), and stubs for
DockerSandbox / E2BSandbox / ModalSandbox tracked in the package
TODO list. ResourceLimits.narrow() enforces that per-call limits can
only tighten construction limits.
display, kernel restart, interrupt) and SubprocessRepl (no extra
dep; persistent variables, error capture, timeout).
Tests extend test/llm/test_llm_transforms.py with TestAgenticParsers
(protocol conformance, call_id stability, round-trip), TestAgenticSandbox
(unsafe-warns, timeout, narrow(), platform-skipped fs-escape and
network-deny negatives), and TestAgenticRepl (state persistence, error
capture, restart, timeout, jupyter slow-marked).
Docs add an "Agentic toolkit (preview)" section under
docs/source/reference/llms_envs.rst documenting Tool contracts, parsers,
sandboxing, and stateful REPLs.
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com