Remove excessive #ifdef HAS_XPUPTI from the code#1337
Open
moksiuc wants to merge 2 commits into
Open
Conversation
xpupti files including into compilation is handled in cmakefiles
Contributor
Author
|
@aostrowski-hbn please help confirm whether we still need this RP. |
Contributor
|
@gujinghui yes we do. I inherited all PRs after Mirosław and currently I think we should still get them all merged. Can I ask you to accept those changes? |
gujinghui
approved these changes
May 8, 2026
Or, we should close this one and create a new PR for it? @aostrowski-hbn |
Contributor
|
Dropping this PR in favor of #1394. I do not have permissions to close it, but if anyone has, please do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xpupti files including into compilation is handled in cmakefiles