Add pathlib Path support to idist broadcast#3755
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
vfdev-5
reviewed
May 21, 2026
Comment on lines
282
to
+287
| if tensor_to_str: | ||
| list_str = self._decode_str(tensor) | ||
| return list_str[0] | ||
| if tensor_to_path: | ||
| list_str = self._decode_str(tensor) | ||
| return Path(list_str[0]) |
Collaborator
There was a problem hiding this comment.
We can merge these two cases into a single one and just apply Path on str if tensor_to_path is True
vfdev-5
reviewed
May 21, 2026
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks for the PR @nightcityblade
As a quick solution this may work. Later we can probably support more types with dist.broadcast_object_list (and this method is present in pytorch 2.2 min supported version by ignite, so we can keep bc etc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3025
Description:
Adds
pathlib.Pathsupport toidist.broadcastby encoding paths through the existing string broadcast path and decoding them back toPathobjects, including safe-mode placeholder handling.Check list: