Skip to content

Enable VGF tests and add Vulkan format compatibility shim (#19383)#19383

Open
psiddh wants to merge 1 commit intopytorch:mainfrom
psiddh:export-D102431804
Open

Enable VGF tests and add Vulkan format compatibility shim (#19383)#19383
psiddh wants to merge 1 commit intopytorch:mainfrom
psiddh:export-D102431804

Conversation

@psiddh
Copy link
Copy Markdown
Contributor

@psiddh psiddh commented May 7, 2026 •
edited by meta-codesync Bot
Loading

Summary:

Two changes to make buck test fbcode//executorch/backends/arm/test:permute -- 'test_permute_vgf' run end-to-end:

Flip _ENABLE_VGF from False to True in fbcode/executorch/backends/arm/test/targets.bzl so the VGF test variants are emitted instead of being skipped with "Did not find model-converter on path".

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: digantdesai, ocvh

Differential Revision: D102431804

Copilot AI review requested due to automatic review settings May 7, 2026 23:33
@psiddh psiddh requested a review from digantdesai as a code owner May 7, 2026 23:33
@pytorch-bot pytorch-bot Bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label May 7, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 7, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19383

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Pending

As of commit 87c7a88 with merge base 91aef57 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 7, 2026

@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102431804.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels May 7, 2026
digantdesai
digantdesai approved these changes May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to enable Arm backend VGF (Vulkan Graph Format) test variants to run end-to-end by default, primarily for the test_permute_vgf path referenced in the description.

Changes:

  • Enable VGF test variants by default by flipping _ENABLE_VGF to True in the Arm test target definitions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread backends/arm/test/targets.bzl
@psiddh psiddh requested a review from 3l1 May 8, 2026 02:17
@meta-codesync meta-codesync Bot changed the title Enable VGF tests and add Vulkan format compatibility shim Enable VGF tests and add Vulkan format compatibility shim (#19383) May 8, 2026
psiddh added a commit to psiddh/executorch that referenced this pull request May 8, 2026
@psiddh @facebook-github-bot
Enable VGF tests and add Vulkan format compatibility shim (pytorch#19383
d9ad97d 
)

Summary:

Two changes to make `buck test fbcode//executorch/backends/arm/test:permute -- 'test_permute_vgf'` run end-to-end:

Flip `_ENABLE_VGF` from `False` to `True` in `fbcode/executorch/backends/arm/test/targets.bzl` so the VGF test variants are emitted instead of being skipped with "Did not find model-converter on path".


bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: digantdesai, ocvh

Differential Revision: D102431804
@psiddh psiddh force-pushed the export-D102431804 branch from 2ee4348 to d9ad97d Compare May 8, 2026 02:18
psiddh added a commit to psiddh/executorch that referenced this pull request May 8, 2026
@psiddh @meta-codesync
Enable VGF tests and add Vulkan format compatibility shim (pytorch#19383
5fb9caf 
)

Summary:
Pull Request resolved: pytorch#19383

Two changes to make `buck test fbcode//executorch/backends/arm/test:permute -- 'test_permute_vgf'` run end-to-end:

Flip `_ENABLE_VGF` from `False` to `True` in `fbcode/executorch/backends/arm/test/targets.bzl` so the VGF test variants are emitted instead of being skipped with "Did not find model-converter on path".

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: digantdesai, ocvh

Differential Revision: D102431804
@psiddh psiddh force-pushed the export-D102431804 branch from d9ad97d to 5fb9caf Compare May 8, 2026 02:55
psiddh added a commit to psiddh/executorch that referenced this pull request May 8, 2026
@psiddh @facebook-github-bot
Enable VGF tests and add Vulkan format compatibility shim (pytorch#19383
521c9eb 
)

Summary:

Two changes to make `buck test fbcode//executorch/backends/arm/test:permute -- 'test_permute_vgf'` run end-to-end:

Flip `_ENABLE_VGF` from `False` to `True` in `fbcode/executorch/backends/arm/test/targets.bzl` so the VGF test variants are emitted instead of being skipped with "Did not find model-converter on path".


bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: digantdesai, ocvh

Differential Revision: D102431804
@psiddh psiddh force-pushed the export-D102431804 branch from 5fb9caf to 521c9eb Compare May 8, 2026 03:19
@psiddh @facebook-github-bot
Enable VGF tests and add Vulkan format compatibility shim (pytorch#19383
87c7a88 
)

Summary:

Two changes to make `buck test fbcode//executorch/backends/arm/test:permute -- 'test_permute_vgf'` run end-to-end:

Flip `_ENABLE_VGF` from `False` to `True` in `fbcode/executorch/backends/arm/test/targets.bzl` so the VGF test variants are emitted instead of being skipped with "Did not find model-converter on path".


bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: digantdesai, ocvh

Differential Revision: D102431804
@psiddh psiddh force-pushed the export-D102431804 branch from 521c9eb to 87c7a88 Compare May 8, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@digantdesai digantdesai digantdesai approved these changes

@zingo zingo zingo approved these changes

@3l1 3l1 Awaiting requested review from 3l1

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported module: arm Issues related to arm backend module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@psiddh @digantdesai @zingo