Qualcomm AI Engine Direct - Fix Full#19359
Qualcomm AI Engine Direct - Fix Full#19359winskuo-quic wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19359
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 17 Unrelated FailuresAs of commit f603e89 with merge base af90130 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
digantdesai
left a comment
There was a problem hiding this comment.
Any test to prevent future regression?
@digantdesai Thanks for reviewing the PR. I have added some UTs that will fail without this change and passes with this PR. |
Summary
Based on reported issue: #19179

2 mathematically equivalent model in nn.Module lowered both lowered to QNN, however, 1 accuracy is good while another is bad. Debugged with qnn_intermediate_debugger and targeted that accuracy drop is possibly caused by
fulloperation. Took a look and noticed the op builder did not take layout transform into consideration.Test plan
Passing tests under test_qnn_delegate.py and fix issue in: #19179