Skip to content

Fix C++ -Werror regressions in llama runner (#19326) #19326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psiddh merged 1 commit into from
May 6, 2026
Merged

Fix C++ -Werror regressions in llama runner (#19326) #19326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/qualcomm/oss_scripts/llama/runner/lhd_token_generator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@ class LhdTokenGenerator : public TokenGenerator<T> {
AttentionSinkRopeRunner* attention_sink_rope_runner) override;

private:
// Bring base class's virtual prepare_io into scope so the overload below
// does not hide it (-Woverloaded-virtual).
using TokenGenerator<T>::prepare_io;
/**
* @brief Fill in I/O buffers with prompt token and position.
* @param cur_token Current token.
Expand Down
3 changes: 3 additions & 0 deletions ...ples/qualcomm/oss_scripts/llama/runner/multimodal_runner/multimodal_lhd_token_generator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,9 @@ class MultimodalLhdTokenGenerator
AttentionSinkRopeRunner* attention_sink_rope_runner) override;

private:
// Bring base class's virtual prepare_io into scope so the overload below
// does not hide it (-Woverloaded-virtual).
using TokenGenerator<T>::prepare_io;
/**
* @brief Fill in I/O buffers with prompt token and position.
* @param cur_token Current token.
Expand Down
2 changes: 2 additions & 0 deletions examples/qualcomm/oss_scripts/llama/runner/prompt_processor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ class PromptProcessor {
const std::string& method_name,
Metadata metadata);

virtual ~PromptProcessor() = default;

/**
* @brief Initialize I/O tensor and allocate I/O data buffer.
* @param buffer_manager Pointer to IMemAlloc instance; by default, it uses a
Expand Down
4 changes: 2 additions & 2 deletions examples/qualcomm/oss_scripts/llama/runner/runner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ Runner<T>::Runner(
std::unique_ptr<tokenizers::Tokenizer> tokenizer,
std::unique_ptr<executorch::extension::Module> attention_sink_rope_module)
: module_(std::move(module)),
attention_sink_rope_module_(std::move(attention_sink_rope_module)),
ngram_(ngram),
window_(window),
gcap_(gcap),
Expand All @@ -111,8 +112,7 @@ Runner<T>::Runner(
temperature_(temperature),
eval_mode_(static_cast<EvalMode>(eval_mode)),
shared_buffer_(shared_buffer),
tokenizer_(std::move(tokenizer)),
attention_sink_rope_module_(std::move(attention_sink_rope_module)) {
tokenizer_(std::move(tokenizer)) {
stats_.reset();

if (decoder_model_version == "llama2") {
Expand Down
Loading