Skip to content

[ET-VK] Fix staging buffer allocation to check all memory types for HOST_CACHED #18291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 2 commits into from
Mar 18, 2026
+6 −7
Merged

[ET-VK] Fix staging buffer allocation to check all memory types for HOST_CACHED #18291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
552a31f
[ET-VK] Fix staging buffer allocation to check all memory types for H…
Mar 18, 2026
c4106b4
Update on "[ET-VK] Fix staging buffer allocation to check all memory …
Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions backends/vulkan/runtime/vk_api/memory/Allocator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,12 @@ VmaAllocationCreateFlags test_host_cached_available(
VkPhysicalDeviceMemoryProperties mem_props;
vkGetPhysicalDeviceMemoryProperties(physical_device, &mem_props);

VkMemoryPropertyFlags const flags = mem_props.memoryTypes->propertyFlags;

bool const host_visible = flags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT;
bool const host_cached = flags & VK_MEMORY_PROPERTY_HOST_CACHED_BIT;

if (host_visible && host_cached) {
return VMA_ALLOCATION_CREATE_HOST_ACCESS_RANDOM_BIT;
for (uint32_t i = 0; i < mem_props.memoryTypeCount; i++) {
VkMemoryPropertyFlags flags = mem_props.memoryTypes[i].propertyFlags;
if ((flags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) &&
(flags & VK_MEMORY_PROPERTY_HOST_CACHED_BIT)) {
return VMA_ALLOCATION_CREATE_HOST_ACCESS_RANDOM_BIT;
}
}

return VMA_ALLOCATION_CREATE_HOST_ACCESS_SEQUENTIAL_WRITE_BIT;
Expand Down
Loading