Restore Conv1d Channel Last Fix (#18290)#18290
Open
JakeStevens wants to merge 1 commit intopytorch:mainfrom
Open
Restore Conv1d Channel Last Fix (#18290)#18290JakeStevens wants to merge 1 commit intopytorch:mainfrom
JakeStevens wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18290
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 6 PendingAs of commit 8f93ceb with merge base 202c6af ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96488193. |
This PR needs a
|
meta-codesync
bot
changed the title
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Mar 18, 2026
Summary: D93658558 accidentally dropped the conv1d check which was added shortly before it, affecting indexing and resulting in incorrect results Differential Revision: D96488193
JakeStevens
force-pushed
the
export-D96488193
branch
from
bff198b to
7bb919b
Compare
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Mar 18, 2026
Summary: Pull Request resolved: pytorch#18290 D93658558 accidentally dropped the conv1d check which was added shortly before it, affecting indexing and resulting in incorrect results Differential Revision: D96488193
JakeStevens
force-pushed
the
export-D96488193
branch
from
7bb919b to
67490e3
Compare
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Mar 18, 2026
Summary: D93658558 accidentally dropped the conv1d check which was added shortly before it, affecting indexing and resulting in incorrect results Reviewed By: hsharma35, mcremon-meta Differential Revision: D96488193
JakeStevens
force-pushed
the
export-D96488193
branch
from
67490e3 to
4394087
Compare
Summary: Pull Request resolved: pytorch#18290 D93658558 accidentally dropped the conv1d check which was added shortly before it, affecting indexing and resulting in incorrect results Reviewed By: hsharma35, mcremon-meta Differential Revision: D96488193
JakeStevens
force-pushed
the
export-D96488193
branch
from
4394087 to
8f93ceb
Compare
mcremon-meta
approved these changes
Mar 18, 2026
hsharma35
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D93658558 accidentally dropped the conv1d check which was added shortly before it, affecting indexing and resulting in incorrect results
Reviewed By: hsharma35, mcremon-meta
Differential Revision: D96488193