Skip to content

Arm backend: Generalize fuse_view_copy_transform_pass#18285

Open
AdrianLundell wants to merge 1 commit intopytorch:mainfrom
AdrianLundell:change-1223321
Open

Arm backend: Generalize fuse_view_copy_transform_pass#18285
AdrianLundell wants to merge 1 commit intopytorch:mainfrom
AdrianLundell:change-1223321

Conversation

@AdrianLundell
Copy link
Collaborator

Update the fuse_view_copy_transform_pass to check shapes rather than args to match different ways of expressing the same shape. This change makes some as_strided ops into noops which they were not previously so an additional noops check is added to fix this.

Additionally moves constants in the pass to class level to simplify overriding behavior for inheriting passes.

Note: test names as_strided_copy -> as_strided since the _copy suffix of operator names are removed in name check.

Update the fuse_view_copy_transform_pass to check shapes
rather than args to match differet ways of expressing the same shape.
This change makes some as_strided ops into noops which they were
not previosuly, so an addtional noops check is added to fix this.

Additionally moves constants in the pass to class level to simplify
overriding behaviour for inheriting passes.

Note: test names as_strided_copy -> as_strided since the _copy
suffix of operator names are removed in name check.

Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
Change-Id: Iba8dc3862c3fc4a8a34e036377ec7bcee84988b1
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 18, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18285

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 1 Awaiting Approval, 3 Unrelated Failures

As of commit 21f1923 with merge base ba54389 (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2026
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant