Skip to content

Remove stale run_and_compare parameter from test calls (#18251)#18251

Open
aliafzal wants to merge 1 commit intopytorch:mainfrom
aliafzal:export-D96985349
Open

Remove stale run_and_compare parameter from test calls (#18251)#18251
aliafzal wants to merge 1 commit intopytorch:mainfrom
aliafzal:export-D96985349

Conversation

@aliafzal
Copy link
Contributor

@aliafzal aliafzal commented Mar 17, 2026

Summary:

export_and_run_model no longer accepts a run_and_compare parameter,
but test_add_op.py and test_g3_ops.py were still passing it. This
removes the stale keyword argument to match the current API.

Differential Revision: D96985349

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 17, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18251

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 6 Unrelated Failures

As of commit 4b9d252 with merge base ed57040 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 17, 2026

@aliafzal has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96985349.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:

`export_and_run_model` no longer accepts a `run_and_compare` parameter,
but `test_add_op.py` and `test_g3_ops.py` were still passing it. This
removes the stale keyword argument to match the current API.

Differential Revision: D96985349
@meta-codesync meta-codesync bot changed the title Remove stale run_and_compare parameter from test calls Remove stale run_and_compare parameter from test calls (#18251) Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant