Add dedicated HiFi kernel for max pool 2d (#18240)#18240

Open

mcremon-meta wants to merge 3 commits intomainfrom

export-D96874522

Contributor

mcremon-meta commented Mar 17, 2026 •

edited by meta-codesync bot

Loading

Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

pytorch-bot bot commented Mar 17, 2026 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18240

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 4 Pending, 1 Unrelated Failure

As of commit 4a14748 with merge base eb92cec ():

NEW FAILURE - The following job has failed:

pull / unittest-editable / windows / windows-job (gh)
Process completed with exit code 1.

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / windows / windows-job (gh) (trunk failure)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla bot added the CLA Signed label

Contributor

meta-codesync bot commented Mar 17, 2026

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96874522.

meta-codesync bot added fb-exported meta-exported labels

hsharma35 approved these changes

View reviewed changes

github-actions bot commented Mar 17, 2026

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

meta-codesync bot changed the title ~~Add dedicated HiFi kernel for max pool 2d~~ Add dedicated HiFi kernel for max pool 2d (#18240)

meta-codesync bot pushed a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

4d2cd10

Summary:

As titled. Calls into nnlib directly.

Differential Revision: D96874522

meta-codesync bot force-pushed the export-D96874522 branch from ece3267 to 4d2cd10 Compare

March 17, 2026 17:46

mcremon-meta added a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

20a30d5

Summary:
Pull Request resolved: #18240

As titled. Calls into nnlib directly.

Differential Revision: D96874522

mcremon-meta force-pushed the export-D96874522 branch from 4d2cd10 to 20a30d5 Compare

March 17, 2026 17:50

meta-codesync bot pushed a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

3b7b0eb

Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

meta-codesync bot force-pushed the export-D96874522 branch from 20a30d5 to 3b7b0eb Compare

March 17, 2026 18:03

mcremon-meta force-pushed the export-D96874522 branch from 3b7b0eb to 4673186 Compare

March 17, 2026 18:06

mcremon-meta added a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

Summary:
Pull Request resolved: #18240

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

meta-codesync bot force-pushed the export-D96874522 branch from 4673186 to 9dca6e0 Compare

March 17, 2026 18:19

meta-codesync bot pushed a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

9dca6e0

Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

meta-codesync bot pushed a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

1f50b69

Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

mcremon-meta added a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

1c82189

Summary:
Pull Request resolved: #18240

As titled. Calls into nnlib directly.

Differential Revision: D96874522

Reviewed By: hsharma35


          Add quantized max_pool2d operator (#18202)

6c6819c

Summary:
Pull Request resolved: #18202

As titled. Useful especially for resnet backbones, to reduce quant/dequant pressure.

Differential Revision: D96683989

Reviewed By: DrJessop

meta-codesync bot force-pushed the export-D96874522 branch from 9dca6e0 to d83857b Compare

March 18, 2026 16:22

meta-codesync bot pushed a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

d83857b

Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

mcremon-meta added a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

Summary:
Pull Request resolved: #18240

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

mcremon-meta force-pushed the export-D96874522 branch from d83857b to 8484491 Compare

March 18, 2026 16:26

meta-codesync bot pushed a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

32d677d

Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

meta-codesync bot pushed a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

096096c

Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

meta-codesync bot force-pushed the export-D96874522 branch from 8484491 to b53954e Compare

March 18, 2026 16:29

meta-codesync bot pushed a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

b53954e

Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522


          Add NHWC version of max_pool2d (#18239)

e3a166f

Summary:
Pull Request resolved: #18239

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Differential Revision: D96869747

Reviewed By: hsharma35

meta-codesync bot pushed a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

8609d9b

Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

meta-codesync bot force-pushed the export-D96874522 branch from b53954e to 8609d9b Compare

March 18, 2026 16:50


          Add dedicated HiFi kernel for max pool 2d (#18240)

4a14748

Summary:
Pull Request resolved: #18240

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

mcremon-meta force-pushed the export-D96874522 branch from 8609d9b to 4a14748 Compare

March 18, 2026 16:53

meta-codesync bot pushed a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

3b21b4c

Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

meta-codesync bot pushed a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

e2d1ad0

Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

mcremon-meta added a commit that referenced this pull request


          Add dedicated HiFi kernel for max pool 2d (#18240)

0cc005a

Summary:
Pull Request resolved: #18240

As titled. Calls into nnlib directly.

Differential Revision: D96874522

Reviewed By: hsharma35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported meta-exported