Arm backend: Add optional ToDevicePass#18230
Open
Erik-Lundell wants to merge 1 commit intopytorch:mainfrom
Open
Arm backend: Add optional ToDevicePass#18230Erik-Lundell wants to merge 1 commit intopytorch:mainfrom
Erik-Lundell wants to merge 1 commit intopytorch:mainfrom
Conversation
A pass to move a graph_module to a device correctly. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I00853022c77ecb60020e8f38c57ad4b1df3725df
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18230
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit d9b147c with merge base 31118d7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
Contributor
|
Any reason not to have this type of pass in backends/transforms or similar? seems backend agnostic |
Collaborator
Author
|
No particular reason. Would you consider this a good solution/ can you get a review for someone that can judge that? If there is a better way, I'd prefer that but if not, let's add it as a backend-agnostic pass. @JakeStevens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pass to move a graph_module to a device correctly. This is needed on models containing ops with "device" kwargs. They are not moved when model.to(device=....) is called.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell