-
Notifications
You must be signed in to change notification settings - Fork 794
Add 'docker-builds' to viable/strict requirement #16282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16282
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 1 Unrelated FailureAs of commit adbfe34 with merge base df626bd ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the docker-builds workflow to the list of required checks that must pass before advancing the viable/strict branch. This ensures that Docker build validation is part of the stability gate for the stable branch, alongside existing requirements like pull, lint, trunk, documentation builds, and Apple platform checks.
Key Changes:
- Adds
"docker-builds"to the requires array in the update-viablestrict workflow configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Need docker builds to pass before we advance viable/strict
Need docker builds to pass before we advance viable/strict
Summary
Need docker builds to pass before we advance viable/strict
Test plan
CI