Adding fixes for im2row and conv1d #16243
Open
+884
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cad-audio
requested review from
kirklandsign and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16243
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 6ccd6ec with merge base 41892be ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
|
@zonglinpeng has imported this pull request. If you are a Meta employee, you can view this in D89198050. |
hsharma35
approved these changes
Dec 22, 2025
hsharma35
approved these changes
Dec 22, 2025
hsharma35
approved these changes
Dec 23, 2025
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 8, 2026
Summary: Summary Adding fixes for im2row and conv1d Pull Request resolved: pytorch#16243 Test Plan: Unit tested topic: not user facing Differential Revision: D89198050 Pulled By: zonglinpeng
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding fixes for im2row and conv1d
Test plan
Unit tested
topic: not user facing