This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Enable linker script optimization for CUDA ARM wheel#1832
Merged
Conversation
tinglvv
changed the title
Contributor
|
@atalman please help prioritize this one |
Aidyn-A
previously approved these changes
May 24, 2024
Contributor
Aidyn-A
left a comment
Aidyn-A
left a comment
There was a problem hiding this comment.
Thank you very much, Ting!
It appears to be working now. Here is the log before this change (https://github.com/pytorch/pytorch/actions/runs/9229148090/job/25394747216?pr=126174 ):
2024-05-24T19:53:00.1145355Z BASE_CUDA_VERSION is set to: cu124
2024-05-24T19:53:00.1146026Z + python /builder/aarch64_linux/aarch64_wheel_ci_build.py --enable-mkldnn --enable-cuda
2024-05-24T19:53:00.1789747Z Building PyTorch wheel
2024-05-24T19:53:00.3634632Z Building wheel torch-2.4.0a0+git090c907
2024-05-24T19:53:00.6837713Z -------------------------------------------------------------------------------------------------
2024-05-24T19:53:00.6838754Z | |
2024-05-24T19:53:00.6839526Z | WARNING: we strongly recommend enabling linker script optimization for ARM + CUDA. |
2024-05-24T19:53:00.6840421Z | To do so please export USE_PRIORITIZED_TEXT_FOR_LD=1 |
2024-05-24T19:53:00.6841104Z | |
2024-05-24T19:53:00.6841833Z -------------------------------------------------------------------------------------------------
2024-05-24T19:53:00.7274827Z running clean
2024-05-24T19:53:00.9344867Z Building OpenBLAS
2024-05-24T19:53:00.9352913Z Cloning into 'OpenBLAS'...
And after the change (https://github.com/pytorch/pytorch/actions/runs/9230224553/job/25398013014?pr=126174):
2024-05-24T21:46:28.1244483Z BASE_CUDA_VERSION is set to: cu124
2024-05-24T21:46:28.1245149Z + python /builder/aarch64_linux/aarch64_wheel_ci_build.py --enable-mkldnn --enable-cuda
2024-05-24T21:46:28.1892538Z Building PyTorch wheel
2024-05-24T21:46:28.3741742Z Building wheel torch-2.4.0a0+git8f729af
2024-05-24T21:46:28.7345907Z running clean
2024-05-24T21:46:28.9416764Z Building OpenBLAS
2024-05-24T21:46:28.9424643Z Cloning into 'OpenBLAS'...
Contributor
Author
|
Thanks @Aidyn-A for pointing out the env var typo and verifying. |
Contributor
Author
|
@pytorchbot rebase |
Contributor
Author
|
Closing as this PR gets |
pytorch-bot
Bot
dismissed stale reviews from nWEIdia and Aidyn-A
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up on https://github.com/pytorch/builder/pull/1828/files.
WAR to enable linker script optimization.
pytorch PR pytorch/pytorch#126174
tested by pytorch/pytorch#127514
cc @Aidyn-A @ptrblck @nWEIdia @atalman