Skip to content

fix: remove refit validator #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zewenli98 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove refit validator #4044

zewenli98 wants to merge 1 commit into from

Conversation

@zewenli98
Copy link
Collaborator

@zewenli98 zewenli98 commented Jan 26, 2026 •
edited
Loading

Description

Remove refit validator for supporting mutable weights for cumsum op.

Fixes #4053

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Jan 26, 2026
@meta-cla meta-cla bot added the cla signed label Jan 26, 2026
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jan 26, 2026
narendasan
narendasan approved these changes Jan 27, 2026
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does TRT support this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan narendasan approved these changes

@cehongwang cehongwang Awaiting requested review from cehongwang

Assignees

@zewenli98 zewenli98

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

↔ [Converter] Remove refit validator for torch.ops.aten.cumsum.default

3 participants

@zewenli98 @narendasan