feat: cms Page & Sitemap list, retrieve API 추가#4
Merged
earthyoung merged 4 commits intomainfrom May 3, 2025
Merged
Conversation
earthyoung
requested review from
JaeHyuckSa and
MU-Software
and removed request for
JaeHyuckSa and
MU-Software
MU-Software
reviewed
May 1, 2025
MU-Software
reviewed
May 1, 2025
MU-Software
reviewed
May 1, 2025
MU-Software
reviewed
May 1, 2025
MU-Software
reviewed
May 1, 2025
MU-Software
reviewed
May 1, 2025
MU-Software
reviewed
May 1, 2025
MU-Software
approved these changes
May 1, 2025
JaeHyuckSa
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cms app의 Page, Sitemap 모델을 목록 조회 및 단건 조회하는 API 코드를 작성했습니다.
중간에 django-modeltranslation과 simple-history 라이브러리를 적용하는 과정에서 AppConfig 부분 코드를 수정했습니다.
django-modeltranslation이 모델에 적용되고 나서 simple-history가 적용되어야 하는데, 이를 위해서 모델에 먼저 simple-history 필드를 선언하는 부분을 없애고 app이 만들어질 때 동적으로 django-modeltranslation을 적용한 다음 simple-history 라이브러리를 register하는 방식을 사용해 봤습니다. 혹시 문제가 있거나 더 좋은 방법을 아신다면 피드백 주시면 감사하겠습니다:)