Merged
Conversation
Signed-off-by: SaJH <wogur981208@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces session time and space concepts by adding Room, RoomSchedule, and CallForPresentationSchedule models, updating the Presentation queryset and serializers, and extending fixtures and tests accordingly.
- Added new models and migrations for rooms and call-for-presentation schedules
- Prefetched new relations in
PresentationQuerySetand exposed them in serializers - Extended test fixtures and updated query count thresholds to accommodate new prefetches
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/event/presentation/test/count_queries_test.py | Increased allowed query count to account for new prefetches |
| app/event/presentation/test/conftest.py | Extended create_presentation_set fixture with Room, RoomSchedule, and CFP schedules |
| app/event/presentation/serializers.py | Added RoomScheduleSerializer, CallForPresentationScheduleSerializer, and fields |
| app/event/presentation/models.py | Prefetched roomschedule_set and call_for_presentation_schedules, added models |
| app/event/presentation/migrations/0008_callforpresentationschedule_room_roomschedule.py | Generated migration for new models |
Comments suppressed due to low confidence (3)
app/event/presentation/test/conftest.py:24
PresentationTestEntitylacks an__init__or@dataclassdecorator, so constructing it with keyword arguments will fail. Add@dataclasses.dataclassabove the class or implement an__init__method.
class PresentationTestEntity:
app/event/presentation/serializers.py:26
- [nitpick] There are no tests covering
RoomScheduleSerializerandCallForPresentationScheduleSerializer. Consider adding serializer unit tests to verify that session time and space fields are correctly serialized.
class RoomScheduleSerializer(serializers.ModelSerializer):
app/event/presentation/test/count_queries_test.py:13
- [nitpick] Raising the allowed query count from 3 to 5 may hide new N+1 issues; consider optimizing the prefetch logic to maintain a lower query count or explicitly document the expected additional queries.
with django_assert_max_num_queries(5):
earthyoung
reviewed
Jul 9, 2025
Contributor
earthyoung
left a comment
There was a problem hiding this comment.
LGTM 같습니다!
개발하시느라 고생하셨습니다:)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.