Skip to content

feat: 세션 시간/공간 개념 추가#25

Merged
JaeHyuckSa merged 1 commit intomainfrom
feature/session-room-schedule
Jul 10, 2025
Merged

feat: 세션 시간/공간 개념 추가#25
JaeHyuckSa merged 1 commit intomainfrom
feature/session-room-schedule

Conversation

@JaeHyuckSa
Copy link
Member

No description provided.

Signed-off-by: SaJH <wogur981208@gmail.com>
@JaeHyuckSa JaeHyuckSa requested review from MU-Software and Copilot and removed request for Copilot July 6, 2025 15:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces session time and space concepts by adding Room, RoomSchedule, and CallForPresentationSchedule models, updating the Presentation queryset and serializers, and extending fixtures and tests accordingly.

  • Added new models and migrations for rooms and call-for-presentation schedules
  • Prefetched new relations in PresentationQuerySet and exposed them in serializers
  • Extended test fixtures and updated query count thresholds to accommodate new prefetches

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
app/event/presentation/test/count_queries_test.py Increased allowed query count to account for new prefetches
app/event/presentation/test/conftest.py Extended create_presentation_set fixture with Room, RoomSchedule, and CFP schedules
app/event/presentation/serializers.py Added RoomScheduleSerializer, CallForPresentationScheduleSerializer, and fields
app/event/presentation/models.py Prefetched roomschedule_set and call_for_presentation_schedules, added models
app/event/presentation/migrations/0008_callforpresentationschedule_room_roomschedule.py Generated migration for new models
Comments suppressed due to low confidence (3)

app/event/presentation/test/conftest.py:24

  • PresentationTestEntity lacks an __init__ or @dataclass decorator, so constructing it with keyword arguments will fail. Add @dataclasses.dataclass above the class or implement an __init__ method.
class PresentationTestEntity:

app/event/presentation/serializers.py:26

  • [nitpick] There are no tests covering RoomScheduleSerializer and CallForPresentationScheduleSerializer. Consider adding serializer unit tests to verify that session time and space fields are correctly serialized.
class RoomScheduleSerializer(serializers.ModelSerializer):

app/event/presentation/test/count_queries_test.py:13

  • [nitpick] Raising the allowed query count from 3 to 5 may hide new N+1 issues; consider optimizing the prefetch logic to maintain a lower query count or explicitly document the expected additional queries.
    with django_assert_max_num_queries(5):

Copy link
Contributor

@earthyoung earthyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 같습니다!
개발하시느라 고생하셨습니다:)

@JaeHyuckSa JaeHyuckSa merged commit d0da6db into main Jul 10, 2025
1 check passed
@JaeHyuckSa JaeHyuckSa deleted the feature/session-room-schedule branch July 10, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants