chore: 모델들에 생성/수정/삭제 관련 필드 추가 및 ViewSet에 필터 추가#11
Merged
MU-Software merged 2 commits intomainfrom May 18, 2025
Merged
Conversation
earthyoung
reviewed
May 18, 2025
| display_end_at = models.DateTimeField(null=True, blank=True) | ||
| # history = HistoricalRecords() | ||
|
|
||
| objects: SitemapQuerySet = SitemapQuerySet.as_manager() |
Contributor
There was a problem hiding this comment.
코멘트는 아니지만 ModelQuerySet 클래스를 생성해서 model의 manager로도 사용할 수 있는 걸 처음 알았네요..!
LGTM입니다:)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
주요 변경 사항
created_atcreated_byupdated_atupdated_bydeleted_atdeleted_byMiddleware나QuerySet단에서 자동으로 생성/수정/삭제한 사람을 넣도록 해줄 예정입니다.Page의list액션과Sitemap의retrieve액션을 제거합니다.ViewSet들에서 유효한 항목들(ex: 삭제되지 않았거나 display_start_at / display_end_at 기간 내에 있는 항목들)만 보이도록 수정합니다.