Skip to content

Fix third party scheduled tests running on forks#525

Merged
JelleZijlstra merged 2 commits intopython:mainfrom
brianschubert:fix-scheduled-tests-on-forks
Dec 22, 2024
Merged

Fix third party scheduled tests running on forks#525
JelleZijlstra merged 2 commits intopython:mainfrom
brianschubert:fix-scheduled-tests-on-forks

Conversation

@brianschubert
Copy link
Contributor

Background in #226, #522

Moves a comment to outside of the if: condition so that the condition doesn't always evaluate to true (see #522 (comment)).

Also did some opportunistic refactoring:

  • Simplified the condition: A || (B && ~A) is equivalent to A || B
  • Refactored the repeated condition into a single predicate job. This way we don't have to repeat the same logic in each test job. I made this change in a separate commit which I can roll back if keeping the original setup is preferred.

@JelleZijlstra JelleZijlstra merged commit 15d48b2 into python:main Dec 22, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants