Skip to content

Experiment: Use 'Any' rather than object in Container #15319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
randolf-scholz wants to merge 1 commit into from
Closed

Experiment: Use 'Any' rather than object in Container #15319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions stdlib/typing.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,9 +642,14 @@ class AsyncGenerator(AsyncIterator[_YieldT_co], Protocol[_YieldT_co, _SendT_cont

@runtime_checkable
class Container(Protocol[_T_co]):
# This is generic more on vibes than anything else
@abstractmethod
def __contains__(self, x: object, /) -> bool: ...
# This Protocol is broken, as it should have used a contravariant type variable.
# But since it has been used in contravariant types, we cannot change it without
# causing breakage.
# Therefore, the key is annotated as `Any`, so that implemented can override it
# appropriately.
# A typical usage in Collection[X] types may be to set it to the upper bound of X.
@abstractmethod
def __contains__(self, x: Any, /) -> bool: ...

@runtime_checkable
class Collection(Iterable[_T_co], Container[_T_co], Protocol[_T_co]):
Expand Down