Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds race condition detection when uploading the PyManager index to prevent conflicting publish steps.
- Modify _run and call_ssh to return command output.
- Introduce race condition checks based on index modification time and missing installs in the uploaded index file.
- Add a helper function to detect missing installations in the index.
Comments suppressed due to low confidence (1)
windows-release/merge-and-upload.py:236
- [nitpick] The variables 'x' and 'y' in the find_missing_from_index function are not descriptive. Consider renaming them to 'indexedKeys' and 'missingKeys' to better reflect their purpose.
x = {install_sortkey(i) for i in json.load(r)["versions"]}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.