Save work on emitting ignored diagnostics #20621
Merged
+183
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
force-pushed
the
skipdiag
branch
from
1489dd8 to
8527b50
Compare
This comment has been minimized.
This comment has been minimized.
hauntsaninja
force-pushed
the
skipdiag
branch
from
8527b50 to
597d019
Compare
This comment has been minimized.
This comment has been minimized.
hauntsaninja
force-pushed
the
skipdiag
branch
from
597d019 to
23a5830
Compare
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
approved these changes
Jan 20, 2026
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Oh wow, I tried something similar in summer, but didn't see big wins. I guess I simply needed to skip it in more places :-) About the renaming: not huge fan TBH I would prefer to rename those back.
Collaborator
|
@hauntsaninja Is something blocking the merge of this PR? I'd love to have the perf increase! |
Collaborator
Author
|
No, just needed to undo the |
for more information, see https://pre-commit.ci
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use this trick a little, but we can be much more aggressive about it.
Best reviewed with whitespace ignored. If the
pure_renames are undesirable it is easy to remove them, just helped me avoid some incorrect changes.This is a 4.5% win on compiled self check