Skip to content

[mypyc]: support :s and :d in generate_format_ops #20534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BobTheBuidler wants to merge 16 commits into
base: master
Choose a base branch
from
+25 −2
Open

[mypyc]: support :s and :d in generate_format_ops #20534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8750faa
[mypyc] feat: support constant folding in `convert_format_expr_to_str`
BobTheBuidler Oct 1, 2025
5bc0c10
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 2, 2025
c5570db
Merge branch 'master' into constant-fold-convert-format
BobTheBuidler Oct 2, 2025
419d2ce
Merge branch 'master' into constant-fold-convert-format
BobTheBuidler Oct 4, 2025
3ebbee5
Merge branch 'master' into constant-fold-convert-format
BobTheBuidler Oct 6, 2025
0ae6611
Merge branch 'master' into constant-fold-convert-format
BobTheBuidler Oct 14, 2025
41a196f
Merge branch 'master' into constant-fold-convert-format
BobTheBuidler Jan 6, 2026
4f9ddf6
irtest
BobTheBuidler Jan 6, 2026
4826244
fix test
BobTheBuidler Jan 6, 2026
f07478a
fix test
BobTheBuidler Jan 6, 2026
174af4a
[mypyc]: support :s and :d in generate_format_ops
BobTheBuidler Jan 6, 2026
4d7a3bc
fix test
BobTheBuidler Jan 6, 2026
6edb7a7
Update irbuild-constant-fold.test
BobTheBuidler Jan 6, 2026
7524bc2
Merge branch 'master' into more-ops
BobTheBuidler Jan 18, 2026
91bc24d
Update constant fold format args output
BobTheBuidler Jan 18, 2026
73a3a9a
Merge branch 'master' into more-ops
BobTheBuidler Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mypyc/irbuild/format_str_tokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ def generate_format_ops(specifiers: list[ConversionSpecifier]) -> list[FormatOp]
format_ops = []
for spec in specifiers:
# TODO: Match specifiers instead of using whole_seq
if spec.whole_seq == "%s" or spec.whole_seq == "{:{}}":
if spec.whole_seq == "%s" or spec.whole_seq in ("{:{}}", ":s"):
format_op = FormatOp.STR
elif spec.whole_seq == "%d":
elif spec.whole_seq in ("%d", ":d"):
format_op = FormatOp.INT
elif spec.whole_seq == "%b":
format_op = FormatOp.BYTES
Expand Down
23 changes: 23 additions & 0 deletions mypyc/test-data/irbuild-constant-fold.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,16 @@ L0:
from typing import Any, Final

FMT: Final = "{} {}"
FMT_D: Final = "{:d} {:s}"
FMT_S: Final = "{:s} {:s}"

def f() -> str:
return FMT.format(400 + 20, "roll" + "up")
def g() -> str:
return FMT_D.format(400 + 20, "roll" + "up")
def h() -> str:
return FMT_S.format(400 + 20, "roll" + "up")
Copy link
Collaborator

@JukkaL JukkaL Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Python, {:s} appears to only support str values. There is no implicit conversion to strings:

>>> '{:s}'.format(2)
Traceback (most recent call last):
  File "<python-input-7>", line 1, in <module>
    '{:s}'.format(2)
    ~~~~~~~~~~~~~^^^
ValueError: Unknown format code 's' for object of type 'int'

I think we should have similar checks to support :s in a compatible way, or apply the optimization if the static type of the corresponding operand is builtins.str perhaps.


[out]
def f():
r0, r1, r2, r3 :: str
Expand All @@ -204,6 +211,22 @@ L0:
r2 = ' '
r3 = CPyStr_Build(3, r0, r2, r1)
return r3
def g():
r0, r1, r2, r3 :: str
L0:
r0 = '420'
r1 = 'rollup'
r2 = ' '
r3 = CPyStr_Build(3, r0, r2, r1)
return r3
def h():
r0, r1, r2, r3 :: str
L0:
r0 = CPyTagged_Str(840)
r1 = 'rollup'
r2 = ' '
r3 = CPyStr_Build(3, r0, r2, r1)
return r3

[case testIntConstantFoldingFinal]
from typing import Final
Expand Down