gh-149180: avoid double checking tp_as_number, tp_as_sequence and tp_as_mapping#149476
Open
NekoAsakura wants to merge 1 commit intopython:mainfrom
Open
gh-149180: avoid double checking tp_as_number, tp_as_sequence and tp_as_mapping#149476NekoAsakura wants to merge 1 commit intopython:mainfrom
tp_as_number, tp_as_sequence and tp_as_mapping#149476NekoAsakura wants to merge 1 commit intopython:mainfrom
Conversation
…e` and `tp_as_mapping`
Documentation build overview
40 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark results
map_check_intmap_check_objseq_check_objseq_check_intseq_check_tupleseq_check_listmap_check_dictmap_check_tuplegetitem_dictmul_str_intmul_int_strmap_check_listmul_int_listmul_list_intgetitem_listgetitem_tuplegetitem_strbool_nonebool_dictbool_listseq_check_dictbool_objbool_intBenchmark scripts
Build flags:
./configure --enable-experimental-jit --enable-optimizations --with-ltoP.S.
Different build flags might affect the benchmarks, but I haven't had the time to test them yet.
I did see a regression on
PyMapping_Checkmatching @picnixz's concern(#149317 (comment)) w/--enable-experimental-jit(no PGO/LTO) build only, but I suspect my testing at the time wasn't sufficiently rigorous. Will take a closer look later.tp_as_number,tp_as_sequenceandtp_as_mapping#149180