gh-145681: reset list allocated to 0#145680
Open
KowalskiThomas wants to merge 3 commits intopython:mainfrom
Open
gh-145681: reset list allocated to 0#145680KowalskiThomas wants to merge 3 commits intopython:mainfrom
KowalskiThomas wants to merge 3 commits intopython:mainfrom
Conversation
KowalskiThomas
changed the title
Contributor
Author
|
I meant to open this PR in my fork until my issue has been reviewed/triaged and bug has been confirmed or rejected but I forgot to select the target repo for the PR... sorry about this. |
Objects/listobject.c
Outdated
| Py_ssize_t size = Py_SIZE(self); | ||
| self->ob_item = NULL; | ||
| Py_SET_SIZE(self, 0); | ||
| self->allocated = 0; |
Contributor
There was a problem hiding this comment.
list_clear_impl has extra code if Py_GIL_DISABLED - should we include it here?
Contributor
Author
There was a problem hiding this comment.
Thanks for the comment, there is a discussion on the issue right now but I'll keep that in mind when time comes.
encukou
approved these changes
Mar 11, 2026
Member
encukou
left a comment
encukou
left a comment
There was a problem hiding this comment.
Looks good!
Do you want to take this out of draft?
Contributor
Author
Oops, yes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for gh-145681.
Note I wanted to open this PR in my fork for the time being (until issue has been reviewed/triaged), but I accidentally opened it in the public CPython directly... Sorry about that.