-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-140189: Use macos-14 runner for iOS CI tests #142444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hugovk I've run the iOS tests 6 times today, and it's passed every time; that's not proof that the "missing simulator" problem is fixed, but it's about as good as we're going to get. As a bonus, it seems to be significantly faster than the macos-15 runner as well (consistently <21 mins, from the look of it). |
hugovk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And revert #142365, or give this a few days to check reliability?
|
I'd say give it a few days, just in case. |
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Switch to the macos-14 runner for iOS CI, working around some instability in the macos-15 runner. (cherry picked from commit 9188483) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
|
GH-142494 is a backport of this pull request to the 3.14 branch. |
|
We're currently seeing a 2-4% failure rate in iOS tests.
This appears to be caused by a problem with the GitHub Actions macos-15 environment; this environment has been having performance issues since August (see actions/runner-images#12777).
This PR reverts to the
macos-14runner, which apparently isn't subject to the issues themacos-15runner is experiencing. This means we'll be running iOS tests on an older iOS release (Xcode 15.4, iOS 17.5); but since we're compiling with iOS 13 compatibility, this shouldn't impact anything.