gh-79638: Treat an unreachable robots.txt as "disallow all"#138555
Merged
serhiy-storchaka merged 5 commits intopython:mainfrom May 7, 2026
Merged
gh-79638: Treat an unreachable robots.txt as "disallow all"#138555serhiy-storchaka merged 5 commits intopython:mainfrom
serhiy-storchaka merged 5 commits intopython:mainfrom
Conversation
serhiy-storchaka
added
needs backport to 3.13
serhiy-storchaka
force-pushed
the
robotparser-unreachable
branch
from
20756b8 to
84119fa
Compare
Disallow all access in urllib.robotparser if the robots.txt file is unreachable due to server or network errors.
serhiy-storchaka
force-pushed
the
robotparser-unreachable
branch
from
84119fa to
317c116
Compare
|
This PR is stale because it has been open for 30 days with no activity. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
GH-149512 is a backport of this pull request to the 3.14 branch. |
|
GH-149513 is a backport of this pull request to the 3.13 branch. |
hugovk
added a commit
to hugovk/cpython
that referenced
this pull request
May 7, 2026
…all" (pythonGH-138555)" This reverts commit 310fe88.
Member
|
This had been set to automerge but was failing CI, so wasn't meant to merge right now. I'd temporarily removed branch protection to be able to merge #149500 which was needed to fix configure, which meant this PR also merged. I've reverted it in #149514 to get @serhiy-storchaka Would you like me to re-open a fresh version of this PR once that is sorted? |
Member
Author
|
I'll recreate it tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disallow all access in urllib.robotparser if the robots.txt file is unreachable due to server or network errors.