gh-106693: Explicitly mark ob_sval as unsigned char to avoid UB#106826
Merged
pablogsal merged 2 commits intopython:mainfrom May 7, 2026
Merged
gh-106693: Explicitly mark ob_sval as unsigned char to avoid UB#106826pablogsal merged 2 commits intopython:mainfrom
pablogsal merged 2 commits intopython:mainfrom
Conversation
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
|
This PR is stale because it has been open for 30 days with no activity. |
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
GH-149510 is a backport of this pull request to the 3.14 branch. |
|
GH-149511 is a backport of this pull request to the 3.13 branch. |
Contributor
|
@pablogsal I might be missing something, but it looks like this breaks a bunch of builds. Doesn't it also have a bunch backwards compatibility concerns? The theoretically fixes undefined behavior seems less important than the actual breaks backwards compatibility |
Member
Author
|
I didn't merge this myself so I don't know what the hell happened here |
Member
Author
|
(Apparently this is a consequence of deactivating branch protections in the release) |
hugovk
added a commit
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.