Allow the GH issue + Section as --flags and take news via stdin#45
Closed
gpshead wants to merge 16 commits intopython:mainfrom
Closed
Allow the GH issue + Section as --flags and take news via stdin#45gpshead wants to merge 16 commits intopython:mainfrom
gpshead wants to merge 16 commits intopython:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At a high level I wanted this feature:
blurb addcommand:-i--issueoption to specify GitHub issue number-s--sectionoption to specify NEWS section-i/--issueand-s/--sectionflags toblurb add#16.--rst-on-stdinoption to read entry content from stdincycloptsfor command line parsing instead of rolling our own to reduce our code size, this changes the help format and brings in a dependency.That led to a rabbit hole, I did the feature in the first commit without cyclopts and really wished we were using it (or the older defopt) given the decorated function pattern being used for commands already.
More code deleted than added while gaining the above features. (until pulling in #16 brought in more, but that makes things nicer anyways)