feat(sources): generate .git_archival.txt for setuptools-scm builds#962
Open
LalatenduMohanty wants to merge 1 commit intopython-wheel-build:mainfrom
Open
Conversation
LalatenduMohanty
force-pushed
the
961_git-archival-for-setuptools-scm
branch
from
16e0021 to
779259f
Compare
Packages using setuptools-scm fail when built from source archives without .git metadata. Add ensure_git_archival() to synthesize a .git_archival.txt with the resolved version, which setuptools-scm reads before PKG-INFO in its fallback chain. Closes: python-wheel-build#961 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty
force-pushed
the
961_git-archival-for-setuptools-scm
branch
from
779259f to
87d777b
Compare
dhellmann
reviewed
Mar 17, 2026
| sdist_root_dir=sdist_root_dir, | ||
| build_dir=build_dir, | ||
| ) | ||
| ensure_git_archival( |
Member
There was a problem hiding this comment.
Why don't we need to check for the .git directory here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages using setuptools-scm fail when built from source archives without .git metadata. Add ensure_git_archival() to synthesize a .git_archival.txt with the resolved version, which setuptools-scm reads before PKG-INFO in its fallback chain.
Closes: #961