fix(resolver): make GitHubTagProvider server URL configurable#1121
fix(resolver): make GitHubTagProvider server URL configurable#1121LalatenduMohanty wants to merge 1 commit intopython-wheel-build:mainfrom
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughAdds a configurable GitHub API server URL to GitHubTagProvider and propagates it through the e2e plugin via the GITHUB_API_URL environment variable. Introduces a minimal local mock GitHub API server (serve.py) and static tags fixture (tags.json), and updates the e2e bootstrap to start and clean up that mock server. Updates tests to expect the new API URL form and cache_key that include the server URL. Replaces local wheel server management with a generic background server framework in e2e/common.sh. Adds a per-file Ruff ignore for the mock server script. Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a95ca0b to
e74b5af
Compare
Add a server_url parameter to GitHubTagProvider, matching the existing GitLabTagProvider pattern. The e2e test now uses a local mock server instead of hitting the real GitHub API, avoiding rate-limit failures in CI (especially for fork PRs without GITHUB_TOKEN). Also extracts a reusable start_background_server helper in common.sh to deduplicate the server lifecycle pattern across e2e tests. Closes: python-wheel-build#1119 Co-Authored-By: Claude <claude@anthropic.com> Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
e74b5af to
f6681de
Compare
|
Closing — fork PRs do get a read-only GITHUB_TOKEN (confirmed in #1122), which is sufficient for the GitHub API tag reads (5,000 req/hr). The rate-limiting concern is not a real problem, so the mock server approach adds complexity without enough benefit. |
Add a server_url parameter to GitHubTagProvider, matching the existing GitLabTagProvider pattern. The e2e test now uses a local mock server instead of hitting the real GitHub API, avoiding rate-limit failures in CI (especially for fork PRs without GITHUB_TOKEN).
Closes: #1119