Skip to content

Switch to use uv.lock instead of test-requirements.txt#3188

Closed
CoolCat467 wants to merge 6 commits intopython-trio:mainfrom
CoolCat467:uv-lock
Closed

Switch to use uv.lock instead of test-requirements.txt#3188
CoolCat467 wants to merge 6 commits intopython-trio:mainfrom
CoolCat467:uv-lock

Conversation

@CoolCat467
Copy link
Copy Markdown
Member

In this pull request, we switch the CI system to use uv.lock instead of test-requirements.txt.

@CoolCat467 CoolCat467 added the dependencies Pull requests that update a dependency file label Jan 19, 2025
@A5rocks
Copy link
Copy Markdown
Contributor

A5rocks commented Jan 20, 2025

I don't like this change (because I install the dependencies using pip install -r test-requirements.txt!), so I'm a -1 here.

My opinion might shift if there's ever a standardized lockfile format though.

@jakkdl
Copy link
Copy Markdown
Member

jakkdl commented Jan 20, 2025

I don't like this change (because I install the dependencies using pip install -r test-requirements.txt!), so I'm a -1 here.

My opinion might shift if there's ever a standardized lockfile format though.

presumably one could use uv sync tests for the same effect? I think that might be faster and stuff. But afaict the current setup works fairly well so I don't have strong opinions either way - maybe time to revisit #2790 and see which, if any, of the pain points brought up are still a thing.

@A5rocks
Copy link
Copy Markdown
Contributor

A5rocks commented May 9, 2026

Actually, there's a standardized lockfile now. Pip's support for it is in beta, but I figure we can switch to it whenever. In particular, it looks like we can swap pip compile requirements.in --universal -o requirements.txt to uv pip compile requirements.in -o pylock.toml (I don't know if we can do test-requirements.in and docs-requirements.in in the same file...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants