Support raw yaml block in tracker#167
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…appy into supprt-raw-yaml-block
for more information, see https://pre-commit.ci
…appy into supprt-raw-yaml-block
for more information, see https://pre-commit.ci
…appy into supprt-raw-yaml-block
for more information, see https://pre-commit.ci
mblayman
left a comment
mblayman
left a comment
There was a problem hiding this comment.
This is looking pretty good. Thanks! I have a couple of minor comments before I'm ready to merge.
| indented_yaml_block = "\n".join( | ||
| f"{indent}{line}" for line in self._yaml_block.splitlines() | ||
| ) | ||
| yaml_block = f"\n{indent}---\n{indented_yaml_block}\n{indent}..." |
There was a problem hiding this comment.
Just checking... should there be a trailing newline here? I suspect the answer is no because is probably printed later, but I would hate to mistakenly combine test line like <end of yaml>...not ok 43 yada yada
| yaml_block = f"\n{indent}---\n{indented_yaml_block}\n{indent}..." | |
| yaml_block = f"\n{indent}---\n{indented_yaml_block}\n{indent}...\n" |
There was a problem hiding this comment.
No newline needed here. in Tracker.generate_tap_report it calls print for each Line object. a Result is still a "Line" (even though it's actually multi-line).
def generate_tap_report(self, test_case, tap_lines, out_file):
self._write_test_case_header(test_case, out_file)
for tap_line in tap_lines:
print(tap_line, file=out_file)
Plus for reassurance, you can see that even if there was no yaml block added, diagnostics in this method did not have a trailing newline either
|
Sigh... my OpenClaw bot is specifically told not to merge PRs that are unrelated to Dependabot. I need to revert this (then go fix my bot to behave properly). Sorry for messing up this PR. |
|
Ah, I see that it finished up my review comment, then decided to merge from there. I'll let this stay merged. |
3 participants
Improve support for YAML blocks: